Skip to content

Fix Universium shader crash #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sisyphussy wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix Universium shader crash #12

sisyphussy wants to merge 7 commits into from

Conversation

@sisyphussy
Copy link

@sisyphussy sisyphussy commented Dec 23, 2025

No longer creates another ShaderProgram that's basically identical to the one in Avaritia

Also a rendering code cleanup (there were some unholy things going on here)

Closes GTNewHorizons/GT-New-Horizons-Modpack#22968

2025-12-23_15 31 14 2025-12-23_16 27 02

@sisyphussy sisyphussy mentioned this pull request Dec 23, 2025
Open
@sisyphussy sisyphussy requested a review from a team December 23, 2025 15:41
@github-actions
Copy link

github-actions bot commented Dec 23, 2025

#13

@github-actions github-actions bot mentioned this pull request Dec 23, 2025
Merged
@github-actions
Spotless apply for branch fix-universium for #12 (#13)
0297dd5 
Co-authored-by: GitHub GTNH Actions <>
glowredman
glowredman reviewed Dec 23, 2025
View reviewed changes
Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change introduce a requirement on a specific min version of Avaritia? If so, please specify this in the @Mod annotation.

@sisyphussy
Copy link
Author

sisyphussy commented Dec 23, 2025

If so, please specify this in the @Mod annotation.

Need GTNewHorizons/Avaritia#67 merged first then.

@sisyphussy
Copy link
Author

sisyphussy commented Dec 23, 2025

Actually nvm, newer versions are still compatible with older avaritia versions since I'm using the shader from GTNHLib now. It's just older versions not being compatible with newer avaritia versions.

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 23, 2025
@glowredman
Copy link
Member

glowredman commented Dec 23, 2025

Then you'll have to

  • mark GTNHLib as required mod here (including the appropriate version)
  • mark the versions of this mod in Avaritia as incompatible (before:modid@(,lastWorkingVer] or before:modid@(,firstIncompatibleVer))

@sisyphussy
Copy link
Author

sisyphussy commented Dec 24, 2025

  • mark the versions of this mod in Avaritia as incompatible (before:modid@(,lastWorkingVer] or before:modid@(,firstIncompatibleVer))

wouldn't this mean eternal singularity is a hard dep on avaritia?

@glowredman
Copy link
Member

glowredman commented Dec 24, 2025

No, before/after are only for load order and (if present) version requirements ("if that mod is present, it must be in this range. Hard deps are either required-after or required-before

@boubou19 boubou19 mentioned this pull request Feb 4, 2026
Open
@sisyphussy
Copy link
Author

sisyphussy commented Feb 11, 2026

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glowredman glowredman Awaiting requested review from glowredman

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

All singularities from "eternal singularity" are shown as fire in NEI

3 participants

@sisyphussy @glowredman @Dream-Master